On 19/07/2013 01:20, Marvin Humphrey wrote:
Obviously we put those version tests there for a reason.

     https://issues.apache.org/jira/browse/LUCY-206

We're not just going to up and remove the previous fixes to fix one particular
config of Perl (5.18.0 with -DNO_MATHOMS) when it's going to break others.
This isn't a working patch, it's a bug report.

It seems we made a good call removing `to_utf8_lower`, since it appears
and disappears seemingly at random from the Perl C API.  How many different
Perls are we going to have to test this on?  Ugh.

I researched this issue and it seems that `to_utf8_lower` was broken by this commit:

http://perl5.git.perl.org/perl.git/commitdiff/051a06d4bf2bf1ff5da602fa4088227becfa244f

Which was fixed about a month later by this commit:

http://perl5.git.perl.org/perl.git/commitdiff/0c9b04389335c3a662232102a5a5a570e4e7c403

So only Perl 5.15.6 (a development version) is affected. I think it's safe to revert the fix from LUCY-206.

Nick

Reply via email to