On Fri, Sep 13, 2013 at 11:31 AM, <[email protected]> wrote: > Convert TextTermStepper to CharBuf
> Project: http://git-wip-us.apache.org/repos/asf/lucy/repo > Commit: http://git-wip-us.apache.org/repos/asf/lucy/commit/56cbd56c > Tree: http://git-wip-us.apache.org/repos/asf/lucy/tree/56cbd56c > Diff: http://git-wip-us.apache.org/repos/asf/lucy/diff/56cbd56c I suspect that having TextTermStepper move away from mutating may have minor performance implications. I ran some benchmarks and found some slight degradation from 0.3 to master and from master to cfish-string-prep1 as of fde94c411c7c73ad35171bb19295f781ed48e0dd -- results below. However, I still support merging the branch, just with the note that this may now be a hotspot to look into when refactoring at some point in the future. Marvin Humphrey =-=-=-=-=-= As of fde94c411c7c73ad35171bb19295f781ed48e0dd: 0.3.3: ------------------------------------------------------------ Lucy 0.003003 Perl 5.12.4 Thread support: yes Darwin 12.4.0 x86_64 Mean: 1.098 secs Truncated mean (26 kept, 24 discarded): 1.089 secs ------------------------------------------------------------ Master: ------------------------------------------------------------ Lucy 0.003 Perl 5.12.4 Thread support: yes Darwin 12.4.0 x86_64 Mean: 1.126 secs Truncated mean (26 kept, 24 discarded): 1.106 secs ------------------------------------------------------------ cfish-string-prep1: ------------------------------------------------------------ Lucy 0.003 Perl 5.12.4 Thread support: yes Darwin 12.4.0 x86_64 Mean: 1.156 secs Truncated mean (26 kept, 24 discarded): 1.147 secs ------------------------------------------------------------
