On Mon, Feb 9, 2015 at 4:55 AM, Nick Wellnhofer <[email protected]> wrote: > On 09/02/2015 07:55, Marvin Humphrey wrote: >> >> The more interesting pull request is the one against Clownfish, which >> didn't trigger a dev list email: >> >> https://github.com/apache/lucy-clownfish/pull/3 > > > Looks great. One remaining issue are the String ivars in Class and Method. > These are immortal and shared across threads, so they need special refcount > handling, too. My original plan was to use a per-object immortal flag, but > I'd prefer a solution that doesn't need such a flag. I think it should work > to use "wrapped" strings in Class and Method and rely on the fact that these > will be copied when incref'd.
I've added a new commit on that branch which implements your suggestion (updating the pull request): https://github.com/rectang/lucy-clownfish/commit/c0b90906746d3825e3fc9fd41d023aa727e07b13
