On Sun, Apr 5, 2015 at 4:23 AM, Nick Wellnhofer <[email protected]> wrote: > On 05/04/2015 02:47, rectang wrote: >> >> commit 9923d78cb6a1f217bffdda3ecf5bb03a37cb283f >> Author: Marvin Humphrey <[email protected]> >> Date: 2015-03-19T17:36:23Z >> >> Add `stdarg.h` to platform includes. > > > Just curious: What's that for?
The autogenerated .h headers derived from .cfh files were failing to compile, because they use va_args and variadic functions. This occurred as I was gradually changing the Go wrappers from hand-coded wrappers around the Clownfish C bindings to a more direct model. Going back now to that commit, if I comment out the stdargs.h addition, everything still works. I must have had my working copy in an inconsistent state at the time. Therefore, I will submit a new pull request which omits this commit. >> commit 35dac58fddcd35d86b61121814c6f25e6c41fd73 >> Author: Marvin Humphrey <[email protected]> >> Date: 2015-03-17T18:04:08Z >> >> Add checks for whether funcs can be bound to Go. > > > I think these checks will be the same for all host languages, so we can > consolidate the *_can_be_bound functions for Perl and Go into a single > version. That sounds good. Since those functions are not yet used, I will also omit the commit which adds them from the new pull request. A future pull request which takes the proof-of-concept design and replaces hand-coded bindings with compiled code will use consolidated functionality per your suggestion. Marvin Humphrey
