On Mon, May 4, 2015 at 10:24 AM, Nick Wellnhofer <[email protected]> wrote:
> I started with the implementation of Blob: > > https://github.com/nwellnhof/lucy-clownfish/commits/CLOWNFISH-11-blob > > I also switched most of Lucy over to Blob: > > https://github.com/nwellnhof/lucy/commits/CLOWNFISH-11-blob Awesome! I've reviewed both branches -- aside from one glitch where Blob_new_steal calls Blob_init rather than Blob_init_steal, they look great! +1 to merge to master. > ByteBufs remain at the following locations: > > * As argument to Read_Record in the default readers. These methods > could be changed to return an incremented Blob, incurring > additional memory allocations. > * `anchor_set` ivar in PhraseMatcher. > * Backing store of RAMFiles. > * MemoryPool arenas. These all seem fine as they are -- they're not dangerous and they are appropriate use cases for ByteBuf (to varying degrees). Marvin Humphrey
