On Mon, May 18, 2015 at 6:28 AM, Nick Wellnhofer <[email protected]> wrote: > On 18/05/2015 15:06, Marvin Humphrey wrote:
>> After a few compatibility tweaks, that branch passes tests on Perl 5.12.5. > > I don't have the infrastructure to test with different Perl versions set up. Best practice would be to get CI working again. We never finished integrating Travis -- if we set up .travis.yml, that would allow you to push to github.com/nwellnhof and fire off a Travis build manually. Then you would have less need for local host language environments. Alternately, perhaps we can get Infra to give us a Linux VM, on which we can install all our host language targets, and allow Lucy committers login. I'm happy to take the lead on this if it makes your life easier. > Maybe you can continue with the branch and commit the changes? All I would do is edit that one commit of yours to restore the unblessing code, and add a comment about why that code is necessary to avoid calling DESTROY. Aside from that, the branch is awesome! I'm psyched that XSBind_enable_overload is going away! The "compatibility" stuff I'm talking about is an accumulation of small problems from past commits -- stuff like the ifdef'd code going stale. I'm happy to start a separate branch fixing those. Any remaining issues are unrelated to your current work. Marvin Humphrey
