GitHub user nwellnhof opened a pull request:
https://github.com/apache/lucy/pull/14
LUCY-279 Obj method removal
This pull request contains some more or less unrelated changes to the way
number fields are handled. It turned out that the Perl bindings didn't support
storing Num objects in number fields from C space. The behavior of number
fields in the C bindings has changed, too. Automatic conversion from Strings to
Nums isn't supported anymore. There are different ways to reenable this
feature, although I don't think it's important.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nwellnhof/lucy LUCY-279-obj-method-removal
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucy/pull/14.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14
----
commit e3c9fa8baa23c077cac7f59e99de41e8f26c89d7
Author: Nick Wellnhofer <[email protected]>
Date: 2015-05-22T13:32:43Z
Convert call to Obj_Mimic
commit 46dd03cda42c08d049ba1413a236b9beb1598a97
Author: Nick Wellnhofer <[email protected]>
Date: 2015-05-22T13:50:03Z
Convert calls to Obj_To_[FI]64 in Json.c
commit 8b4f06069348c6f2aff545fcc63b2bc551c7cdec
Author: Nick Wellnhofer <[email protected]>
Date: 2015-05-23T13:11:30Z
Helper functions to extract numbers from JSON data
Prepare for the removal of Obj_To_I64, Obj_To_F64, and Obj_To_Bool.
commit b5c9cf9c5fea59fc25c35540fd4ca241c35087d6
Author: Nick Wellnhofer <[email protected]>
Date: 2015-05-23T13:24:43Z
Convert calls to Obj_To_* to Json helpers
commit 684e52b002ae71ec2f94a6373d5b17f4ef4ac0f2
Author: Nick Wellnhofer <[email protected]>
Date: 2015-05-23T14:35:24Z
Store number fields in documents as Perl IVs and NVs
Inverter_Invert_Doc expects IVs or NVs in number fields. It would be
more efficient if Clownfish::Objs were supported as well. But this
matters only in the unusual case of creating documents from C space
like in the test suite.
commit dbcce56917b4fd2acba8931a9e95a56f54959511
Author: Nick Wellnhofer <[email protected]>
Date: 2015-05-23T14:56:17Z
Make TestSortSpec store Num objects in number fields
commit c0ab70d3eef4932987c3bcffe0f115effb8659f0
Author: Nick Wellnhofer <[email protected]>
Date: 2015-05-23T14:57:37Z
Switch to Num_Mimic in C version of Inverter
Simplifies the code and removes calls to Obj_To_[FI]64.
As a side effect, the C bindings don't accept Strings in a document's
Num field anymore.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
