GitHub user rectang opened a pull request:
https://github.com/apache/lucy-clownfish/pull/26
CLOWNFISH-32 Go constructor autogen
Autogenerate Go constructor bindings.
The constructors follow Go naming conventions, following the
proof-of-concept bindings: `NewFoo()`
Subtyping is not supported. Under the hood, we use the inert function
`new` when available -- unlike the Perl bindings, which use `init`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rectang/lucy-clownfish
CLOWNFISH-32-go-ctor-autogen
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucy-clownfish/pull/26.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #26
----
commit fffd970490b37a1c53cdef0afa78272aee9dc2eb
Author: Marvin Humphrey <[email protected]>
Date: 2015-07-11T23:01:41Z
Add placeholder for generated constructors.
commit 3f6266df84139f93812015400e67f64d2eb733f6
Author: Marvin Humphrey <[email protected]>
Date: 2015-07-14T00:21:14Z
Generalize Go-to-cfish arg list prep.
Make the functionality which converts Go argument lists to
Clownfish-flavored-C argument lists more widely available.
commit 858fa345086d119f750544449ba78a8545603860
Author: Marvin Humphrey <[email protected]>
Date: 2015-07-14T00:57:29Z
Generalize Go func first line conversion.
Prepare to make the conversion function which generates the first part
of a Go method binding work with constructors and inert functions in
addition to methods.
commit 5c86308e5ed25c74d1c0b5568f3acbae336e759a
Author: Marvin Humphrey <[email protected]>
Date: 2015-07-14T02:03:41Z
Auto-generate Go bindings for constructors.
commit e340a510dbcd00ea44aecc97101d9da88fa19805
Author: Marvin Humphrey <[email protected]>
Date: 2015-07-14T19:01:13Z
Make Err constructor public.
commit da43ffd0af8c862dfc4598f11bb9cd7de5e6b760
Author: Marvin Humphrey <[email protected]>
Date: 2015-07-14T19:08:58Z
Ensure that converted args outlive call.
Eliminate a race condition by ensuring that the refcount decrement of a
converted argument does not happen until after the call into C
completes.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
