GitHub user rectang opened a pull request:
https://github.com/apache/lucy-clownfish/pull/41
CLOWNFISH-63 Don't export private methods via Go
Clownfish methods which are not marked as `public` should have the first
letter of their Go method name downcased so that they are not exported by the
Go package.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rectang/lucy-clownfish
CLOWNFISH-63-Go-private-no-export
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucy-clownfish/pull/41.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #41
----
commit a0a3c6dbe59e7bdf64293c68032e1528345b7a63
Author: Marvin Humphrey <[email protected]>
Date: 2015-11-04T02:02:16Z
Make 3 TestSuite methods public.
Make `Add_Batch`, `Run_Batch`, and `Run_All_Batches` public.
commit f92a6fc6352acfdcf2b66513ea639cd009d6cfaf
Author: Marvin Humphrey <[email protected]>
Date: 2015-11-04T02:47:49Z
Don't export private methods via Go.
Downcase the first letter of the Go method name for methods not marked
as `public`, so that they are not exported by the Go package.
commit 53eba3b39a33d254524f7ab3eea921d6e3d29cdb
Author: Marvin Humphrey <[email protected]>
Date: 2015-11-04T02:49:09Z
Adapt to changes in Go names for private methods.
Downcase the first letter of Go method names as required by recent API
changes for Go bindings for private methods. Such methods are only
called from internal code and tests.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
