Lucifers,

Currently, Lucy uses CharBuf in two ways. One is to build Strings which is the typical use case. In two places they're used as a resizable buffer to hold UTF-8 data.

S_write_terms_and_postings in PostingPool:

    
https://github.com/apache/lucy/blob/master/core/Lucy/Index/PostingPool.c#L356

In TextTermStepper:

    https://github.com/apache/lucy/blob/master/core/Lucy/Plan/TextType.c

I'm wondering whether we should restrict CharBuf to string building and rename it to something like StringBuilder. This would allow to remove a couple of methods. For resizable buffers, users could switch to ByteBuf, maybe with additional convenience methods to get Strings in and out of ByteBufs.

Nick

Reply via email to