On Thu, Nov 5, 2015 at 12:48 PM, nwellnhof <[email protected]> wrote: > GitHub user nwellnhof opened a pull request: > > https://github.com/apache/lucy/pull/27 > > Improve SortExternal > > My main motivation was to switch to a custom implementation of > Clownfish's `Sort_merge`. I added some improvements to > `S_absorb_slices` along the way.
+1 to merge. Thank you for diving in! SortExternal is fairly large, fairly easy to make mistakes in, and not that easy to keep in your head. I scrutinized these commits closely enough to satisfy myself that I couldn't find any local mistakes in the diffs, and that if there were any big conceptual mistakes, they would probably have caused the whole module to blow up. Marvin Humphrey
