On Fri, Mar 4, 2016 at 6:37 AM, Nick Wellnhofer <[email protected]> wrote:
> [ ] +1 Release RC 1 as Apache Clownfish 0.5.0. > [ ] +0 > [ ] -1 Do not release RC 1 as Apache Clownfish 0.5.0 because... +1 I tested the release candidate on Amazon Linux and Mac OS X El Capitan, using Lucy's test_all.sh: Go, C and Perl are all working. There are more compiler warnings than I'd prefer, but I don't think those should block the release at this point. I also tested Python on both OS X and Amazon Linux. The build is quite fragile, which is a known issue since the bindings are nascent. Amazon Linux required the addition of `extra_compile_args = ["-std=gnu99"],` to the `Extension` constructor in setup.py -- after that, it built and passed what tests we have. The `test_valgrind` build target passed on Amazon Linux for both CFC and the Clownfish runtime under the Perl bindings. LICENSE, NOTICE, CONTRIBUTING.md, INSTALL.md, and README.md all looked good in a spot check -- except for one thing. The copyright notice in NOTICE still reads 2014 and should have been updated to 2016. This isn't the end of the world though, and I'm still willing to vote +1 despite it. I ran the tarball through http://compliance.rocks and everything looked good. Sums and sigs check out. Let's get this show on the road! PS: Apologies for the delayed vote -- a relative in my extended family passed away recently. Marvin Humphrey
