GitHub user nwellnhof opened a pull request:
https://github.com/apache/lucy-charmonizer/pull/2
Separate detection of shell and binary format
Detect shell by escape character. This should be more robust than
looking for /dev/null files.
Detect binary format by looking at the magic bytes of a compiled
executable.
Move information about binary format and file extensions to Compiler.
That's where it belongs if you think about cross-compiling.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nwellnhof/lucy-charmonizer binfmt
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucy-charmonizer/pull/2.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2
----
commit 14f5139110eebd01af00999a472de097d5b6e492
Author: Nick Wellnhofer <[email protected]>
Date: 2016-05-21T16:59:20Z
Separate detection of shell and binary format
Detect shell by escape character. This should be more robust than
looking for /dev/null files.
Detect binary format by looking at the magic bytes of a compiled
executable.
Move information about binary format and file extensions to Compiler.
That's where it belongs if you think about cross-compiling.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
