GitHub user nwellnhof opened a pull request:
https://github.com/apache/lucy-charmonizer/pull/3
Improve binary format and shell detection
This pull request separates the detection of the target platform's binary
format and the OS shell. The binary format and file extensions are moved from
OperatingSystem to Compiler. They are properties of the compiler after all,
especially when cross-compiling. The binary format is detected by inspecting a
compiled executable for magic values.
On Windows, we now try to detect whether a POSIX-compatible environment can
be used indirectly by invoking `sh.exe` via `cmd.exe`. This is needed to make
the build work under MSYS and MSYS2 with native MinGW targets.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nwellnhof/lucy-charmonizer
binfmt-and-shell-detection
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucy-charmonizer/pull/3.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3
----
commit e3b57156cde95a9e74039e5bad2d74dff6674380
Author: Nick Wellnhofer <[email protected]>
Date: 2016-05-21T16:59:20Z
Separate detection of shell and binary format
Detect shell by escape character. This should be more robust than
looking for /dev/null files.
Detect binary format by looking at the magic bytes of a compiled
executable.
Move information about binary format and file extensions to Compiler.
That's where it belongs if you think about cross-compiling.
commit 76e4dbe39532675b31f7756cb3f84f8fea3807e4
Author: Nick Wellnhofer <[email protected]>
Date: 2016-05-31T10:40:51Z
Fix add_command_with_libpath on Cygwin
Fixes LUCY-303.
commit 41d940779ee7b022251fc422cff7132b80ef54f7
Author: Nick Wellnhofer <[email protected]>
Date: 2016-05-31T11:14:19Z
Readd Cygwin detection
Also add a new public function chaz_CC_has_macro.
commit c5387af383d317dcd887f9e07769c589039e099c
Author: Nick Wellnhofer <[email protected]>
Date: 2016-06-01T18:57:27Z
Support POSIX shells under MinGW
Fixes CLOWNFISH-100.
commit 7f2cb31d06aeaf46499785aabfa3eb4bcf9d1b7b
Author: Nick Wellnhofer <[email protected]>
Date: 2016-06-01T19:35:25Z
Rework detection of directory separator
Use _WIN32 and __CYGWIN__ macros to detect Windows directory separators.
commit f324690a7d9a810e3c1bd93aec7ae982de2b227f
Author: Nick Wellnhofer <[email protected]>
Date: 2016-06-01T19:50:25Z
Check whether the make command matches the OS shell
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
