On Fri, Dec 9, 2016 at 8:29 AM, Nick Wellnhofer <[email protected]> wrote:
> All CI tests passed: > > https://travis-ci.org/apache/lucy/builds/182635046 > https://ci.appveyor.com/project/Humbedooh/lucy/build/1.0.92 So nice... :) > [ ] +1 Release RC 1 as Apache Lucy 0.6.1. > [ ] +0 > [ ] -1 Do not release RC 1 as Apache Lucy 0.6.1 because... +1 I found a small discrepancy between the content of the git tag and the content of the release tarball: there are 2 lines missing from CHANGES in the tarball. See below my sig. My suggestion is to make a commit and update the tag before it is made permanent by moving it under `rel/`. Rerolling a release candidate would be overkill, but it is good for the tag and the tarball to match. It is not critical that CHANGES be exhaustively complete. Other things I checked: * Sums and sigs check out. * The `test_valgrind` build target for Perl, run on Amazon linux, did not reveal any substantial problems. * The `test_all.sh` script passed on OS X El Capitan - Apple LLVM version 8.0.0 (clang-800.0.42.1) - stock Perl 5.18.2 - go 1.4.2 * Though I've been quiet on-list lately, I've reviewed all commits. * The issue tracker is clean. * Copyright dates look good. Marvin Humphrey marvin@nicodemus:~/Desktop/release $ diff -ur ~/projects/lucy lucy Only in /Users/marvin/projects/lucy: .git diff -ur /Users/marvin/projects/lucy/CHANGES lucy/CHANGES --- /Users/marvin/projects/lucy/CHANGES 2016-12-10 16:28:58.000000000 -0800 +++ lucy/CHANGES 2016-12-09 07:50:05.000000000 -0800 @@ -5,10 +5,8 @@ Bugfixes: * [LUCY-286] - Remote::SearchClient::DESTROY shouldn't throw exceptions - * [LUCY-309] - BSD make doesn't support pattern rules * [LUCY-310] - CPAN dist includes Lucy/Test.xs * [LUCY-311] - Non-ASCII error messages from strerror cause exceptions - * [LUCY-312] - Remote searcher tests fail if port is in use * [LUCY-315] - Memory leak in HitQueue with SortSpec * [LUCY-316] - Don't regenerate POD when building CPAN distro * [LUCY-317] - Compile failure on FreeBSD 10.1
