Github user jingyimei commented on a diff in the pull request:

    https://github.com/apache/incubator-madlib/pull/177#discussion_r135934476
  
    --- Diff: src/ports/postgres/modules/graph/pagerank.py_in ---
    @@ -30,6 +30,8 @@
     import plpy
     from utilities.control import MinWarning
     from utilities.utilities import _assert
    +from utilities.utilities import _check_groups
    +from utilities.utilities import _grp_from_table
    --- End diff --
    
    Currently, these functions are not used in pagerank, but similar 
functionalities are implemented. We should refactor those pagerank-customized 
implementations to use these functions. For instance the variables 
`group_by_clause` and `grouping_where_clause` can be created using the above 
functions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to