GitHub user edespino opened a pull request:

    https://github.com/apache/madlib/pull/182

    MADLIB-1154. PostgreSQL 10 (beta 4) support.

    **Postgres 10 header file movement**
    
      Move some things from builtins.h to new header files
      
https://github.com/postgres/postgres/commit/f21a563d25dbae153937aec062161184189478b8
    
      o format_procedure has moved into utils/regproc.h (from
        utils/builtins.h)
    
      o Functions for the variable-length built-in types moved into
        utils/varlena.h (from utils/builtins.h)
    
    **libpq/md5.h has moved to common/md5.h**
    
      Postgres 10 change
      Move code shared between libpq and backend from backend/libpq/ to common/.
      
https://github.com/postgres/postgres/commit/ec136d19b21791c845b1deeff43df137add0639e
    
    **Convert sketch to Version 1 Calling Conventions.**
    
    **Update "is_less_than_pg90" to accommodate "10beta" version.**
    
    **PlEASE NOTE** The Postgres Beta string is non-standard and I have been 
able to account for it in "is_less_than_pg90". There are other checks when 
installing madlib and running install-check that fail and it fallbacks to using 
the newest supported version. Here is the message received:
    
    > Could not parse version string reported by PostgreSQL. Will default to 
newest supported version of PostgreSQL (10.0).
    
    For reference, this is the "select_version()" output for Postgres 10 beta4:
    
    ```
    psql -c "select version()"
                                                        version                 
                                    
    
----------------------------------------------------------------------------------------------------------------
     PostgreSQL 10beta4 on x86_64-apple-darwin16.7.0, compiled by Apple LLVM 
version 8.1.0 (clang-802.0.42), 64-bit
    (1 row)
    
    ```
    I have successfully built and run install/install-check against PostgreSQL 
9.6 and 10beta4.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/edespino/madlib MADLIB-1154

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/madlib/pull/182.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #182
    
----
commit 12f6c2047c3bf20e48fdb128a4fc158eaf14c47c
Author: Ed Espino <[email protected]>
Date:   2017-08-17T23:01:22Z

    MADLIB-1154. PostgreSQL 10 (beta 4) support.
    
    - Postgres 10 header file movement
    
      Move some things from builtins.h to new header files
      
https://github.com/postgres/postgres/commit/f21a563d25dbae153937aec062161184189478b8
    
      o format_procedure has moved into utils/regproc.h (from
        utils/builtins.h)
    
      o Functions for the variable-length built-in types moved into
        utils/varlena.h (from utils/builtins.h)
    
    - libpq/md5.h has moved to common/md5.h
    
      Postgres 10 change
      Move code shared between libpq and backend from backend/libpq/ to common/.
      
https://github.com/postgres/postgres/commit/ec136d19b21791c845b1deeff43df137add0639e
    
    - Convert sketch to Version 1 Calling Conventions.
    
    - Update "is_less_than_pg90" to accommodate "10beta" version.

----


---

Reply via email to