Github user edespino commented on the issue:
https://github.com/apache/madlib/pull/181
I ran the shell script analysis tool (available via brew
[shellcheck](https://www.shellcheck.net/)). It reported a few issues with the
script:
```
â-1 ~/workspace/MADlib/madlib/tool [PR-181 L|â¦1]
17:40 $ shellcheck --version
ShellCheck - shell script analysis tool
version: 0.4.6
license: GNU General Public License, version 3
website: http://www.shellcheck.net
â ~/workspace/MADlib/madlib/tool [PR-181 L|â¦1]
17:40 $ shellcheck docker_start.sh
In docker_start.sh line 33:
workdir=`pwd`
^-- SC2006: Use $(..) instead of legacy `..`.
In docker_start.sh line 34:
user_name=`whoami`
^-- SC2006: Use $(..) instead of legacy `..`.
In docker_start.sh line 77:
docker exec madlib-test bash -c 'rm -rf /build; mkdir /build; cd /build;
cmake ../madlib; make clean; make; make install' | tee
$workdir/logs/madlib_compile.log
^-- SC2086: Double quote to
prevent globbing and word splitting.
In docker_start.sh line 84:
docker exec madlib-test bash -c '/build/src/bin/madpack -p postgres -c
postgres/postgres@localhost:5432/postgres install' | tee
$workdir/logs/madlib_install.log
^-- SC2086: Double quote to
prevent globbing and word splitting.
In docker_start.sh line 92:
docker exec madlib-test bash -c '/build/src/bin/madpack -p postgres -c
postgres/postgres@localhost:5432/postgres -d /tmp install-check' | tee
$workdir/logs/madlib_install_check.log
^-- SC2086:
Double quote to prevent globbing and word splitting.
In docker_start.sh line 99:
docker exec --user=postgres -it madlib-test bash | tee
$workdir/logs/docker_exec.log
^-- SC2086: Double
quote to prevent globbing and word splitting.
â-1 ~/workspace/MADlib/madlib/tool [PR-181 L|â¦1]
17:40 $
```
---
