Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/191#discussion_r146701746
--- Diff: src/ports/postgres/modules/knn/knn.sql_in ---
@@ -218,56 +215,57 @@ INSERT INTO knn_test_data VALUES
-# Run KNN for classification:
<pre class="example">
-DROP TABLE IF EXISTS madlib_knn_result_classification;
-SELECT * FROM madlib.knn(
+DROP TABLE IF EXISTS knn_result_classification;
+SELECT * FROM madlib.knn(
'knn_train_data', -- Table of training data
'data', -- Col name of training data
- 'id', -- Col Name of id in train data
+ 'id', -- Col Name of id in train data
'label', -- Training labels
'knn_test_data', -- Table of test data
'data', -- Col name of test data
- 'id', -- Col name of id in test data
- 'madlib_knn_result_classification', -- Output table
- 3 -- Number of nearest neighbours
+ 'id', -- Col name of id in test data
+ 'knn_result_classification', -- Output table
+ 3, -- Number of nearest neighbors
True -- True if you want to show
Nearest-Neighbors, False otherwise
--- End diff --
We can say "True if you want to show Nearest-Neighbors by id" to make it
clearer
---
