Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/195#discussion_r151061922
--- Diff: src/ports/postgres/modules/utilities/utilities.py_in ---
@@ -709,16 +709,35 @@ def _check_groups(tbl1, tbl2, grp_list):
return ' AND '.join([" {tbl1}.{i} = {tbl2}.{i} ".format(**locals())
for i in grp_list])
-
-def _grp_from_table(tbl, grp_list):
- """
- Helper function for selecting grouping columns of a table
+def get_filtered_cols_subquery_str(include_from_table, exclude_from_table,
--- End diff --
what is our consideration to define function name not start with
underscore(weak internal use) while the previous one is a weak internal use?
---
