Github user kaknikhil commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/218#discussion_r157893105
  
    --- Diff: src/ports/postgres/modules/sample/test/balance_sample.sql_in ---
    @@ -93,8 +93,8 @@ SELECT assert(sum(c) <= 18, 'Wrong number of samples') 
FROM
     
     DROP TABLE IF EXISTS out_sr3;
     SELECT balance_sample('"TEST_s"', 'out_sr3', 'gr2', 'undersample', NULL, 
NULL, TRUE);
    -select assert(sum(c) <= 12, 'Wrong number of samples') from 
    -        (select gr2, count(*) as c from out_sr3 group by gr2) as foo;
    +select assert(count(*) = 0, 'Wrong number of samples') from 
    --- End diff --
    
    the same changes can be made to all the other tests as well. 


---

Reply via email to