Github user njayaram2 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/227#discussion_r162219833
--- Diff: tool/docker/base/Dockerfile_postgres_9_6 ---
@@ -1,71 +0,0 @@
-#
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-FROM postgres:9.6
-
-### Get postgres specific add-ons
-RUN apt-get update && apt-get install -y wget \
- build-essential \
- postgresql-server-dev-9.6 \
- postgresql-plpython-9.6 \
- openssl \
- libssl-dev \
- libboost-all-dev \
- m4 \
- wget \
- vim \
- pgxnclient \
- flex \
- bison \
- graphviz
-
-### Build custom CMake with SSQL support
-RUN wget https://cmake.org/files/v3.6/cmake-3.6.1.tar.gz && \
- tar -zxvf cmake-3.6.1.tar.gz && \
- cd cmake-3.6.1 && \
- sed -i 's/-DCMAKE_BOOTSTRAP=1/-DCMAKE_BOOTSTRAP=1
-DCMAKE_USE_OPENSSL=ON/g' bootstrap && \
- ./configure && \
- make -j2 && \
- make install
-
-### Install doxygen-1.8.13:
-RUN wget http://ftp.stack.nl/pub/users/dimitri/doxygen-1.8.13.src.tar.gz
&& \
- tar xf doxygen-1.8.13.src.tar.gz && \
- cd doxygen-1.8.13 && \
- mkdir build && \
- cd build && \
- cmake -G "Unix Makefiles" .. && \
- make && \
- make install
-
-### Optional: install LaTex
-### uncomment the following 'RUN apt-get' line to bake LaTex into the image
-### Note: if you run the following line, please tag the image as
-### madlib/postgres_9.6:LaTex, and don't tag it as latest
-# RUN apt-get install -y texlive-full
--- End diff --
Please retain this comment too in the new docker files. `texlive-full` is
big to have it as part of the image, so developers can refer to this to figure
out the exact command to install latex. It is required to build the design doc.
---
