GitHub user iyerr3 opened a pull request:
https://github.com/apache/madlib/pull/242
PCA: Fix issue with text grouping col input
JIRA: MADLIB-1215
PCA fails when the grouping column is a text column (a common use case).
This is because the column is compared to its values in a where
clause with the value not quoted. This commit adds single quotes around
the value.
Other changes include whitespace cleanup and PEP8 conforming changes.
Closes #242
Note to reviewers: It would help to see the diff without the whitespace
changes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/madlib/madlib bugfix/pca_grouping_text
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/madlib/pull/242.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #242
----
commit cf4ce67fac9309281d5215c264904f05bd7d93bb
Author: Rahul Iyer <riyer@...>
Date: 2018-03-15T00:54:22Z
PCA: Fix issue with text grouping col input
JIRA: MADLIB-1215
PCA fails when the grouping column is a text column (a common use case).
This is because the column is compared to its values in a where
clause with the value not quoted. This commit adds single quotes around
the value.
Other changes include whitespace cleanup and PEP8 conforming changes.
Closes #242
----
---
