[GitHub] madlib pull request #244: Changes for Personalized Page Rank : Jira:1084

[jingyimei]

Github user jingyimei commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/244#discussion_r175664342
  
    --- Diff: src/ports/postgres/modules/graph/test/pagerank.sql_in ---
    @@ -84,7 +89,8 @@ SELECT pagerank(
                  NULL,
                  NULL,
                  NULL,
    -             'user_id');
    +             'user_id',
    +             NULL);
     
     -- View the PageRank of all vertices, sorted by their scores.
     SELECT assert(relative_error(SUM(pagerank), 1) < 0.00001,
    --- End diff --
    
    We may need at least two test cases with nodes_of_interest not null and 
with/without grouping.


---