Github user kaknikhil commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/243#discussion_r175917822
  
    --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in ---
    @@ -222,67 +243,83 @@ def mlp(schema_madlib, source_table, output_table, 
independent_varname,
         it_args.update({
             'group_by_clause': group_by_clause,
             'using_clause': using_clause,
    -        'grouping_str_comma': grouping_str_comma
    +        'grouping_str_comma': grouping_str_comma,
         })
     
         first_try = True
         temp_output_table = unique_string(desp='temp_output_table')
    +
    +    layer_sizes = [num_input_nodes] + hidden_layer_sizes + 
[num_output_nodes]
    --- End diff --
    
    we already did this at line 176. is this intentional?


---

Reply via email to