Github user iyerr3 commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/246#discussion_r175927937
  
    --- Diff: 
src/ports/postgres/modules/recursive_partitioning/decision_tree.sql_in ---
    @@ -418,7 +468,10 @@ tree_predict(tree_model,
       <DT>new_data_table</DT>
       <DD>TEXT. Name of the table containing prediction data. This table is
       expected to contain the same features that were used during training. 
The table
    -  should also contain <em>id_col_name</em> used for identifying each 
row.</DD>
    +  should also contain <em>id_col_name</em> used for identifying each row.
    +
    +  If the <em>new_data_table</em> contains categorical variables
    --- End diff --
    
    Are we sure of this? We use majority branch in most cases when the feature 
does not provide a path. 


---

Reply via email to