Github user jingyimei commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/241#discussion_r175957056
  
    --- Diff: 
src/ports/postgres/modules/utilities/mean_std_dev_calculator.py_in ---
    @@ -0,0 +1,54 @@
    +# coding=utf-8
    +#
    +# Licensed to the Apache Software Foundation (ASF) under one
    +# or more contributor license agreements.  See the NOTICE file
    +# distributed with this work for additional information
    +# regarding copyright ownership.  The ASF licenses this file
    +# to you under the Apache License, Version 2.0 (the
    +# "License"); you may not use this file except in compliance
    +# with the License.  You may obtain a copy of the License at
    +#
    +#   http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing,
    +# software distributed under the License is distributed on an
    +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +# KIND, either express or implied.  See the License for the
    +# specific language governing permissions and limitations
    +# under the License.
    +"""
    +@file mean_std_dev_calculator.py_in
    +
    +@brief
    +
    +@namespace utilities
    +
    +"""
    +
    +from convex.utils_regularization import utils_ind_var_scales
    +from utilities import _array_to_string
    +
    +m4_changequote(`<!', `!>')
    +
    +#TODO: use this for all the modules that calculate the std dev and mean 
for x
    +# mlp, pca, elastic_net
    --- End diff --
    
    Yes the TODO comment is left here for future reference. The idea is that 
whenever we update any of these modules, we can refactor the code to call this 
class. 


---

Reply via email to