Github user kaknikhil commented on the issue:
https://github.com/apache/madlib/pull/247
@iyerr3
I compared this PR with the original commit and it looks good. Just a
couple of minor questions
1. This change to model.hpp was not reverted. It looks like it's not
related to minibatch but just wanted to confirm it with you
```
- for (k = 1; k <= N; k ++) {
- u.push_back(Eigen::Map<Matrix >(
- const_cast<double*>(data + sizeOfU),
- n[k-1] + 1, n[k]));
- sizeOfU += (n[k-1] + 1) * (n[k]);
+ for (k = 0; k < N; k ++) {
+ // u.push_back(Eigen::Map<Matrix >(
+ // const_cast<double*>(data + sizeOfU),
+ // n[k] + 1, n[k+1]));
+ u.push_back(MutableMappedMatrix());
+ u[k].rebind(const_cast<double *>(data + sizeOfU), n[k] + 1,
n[k+1]);
+ sizeOfU += (n[k] + 1) * (n[k+1]);
```
2. A function named `initialize` was added to model.hpp but I didn't see it
getting used anywhere. Should this be reverted as well ?
I also cherry picked this revert commit on top of the mlp minibatch branch
`mlp-minibatch-with-preprocessed-data-rebased` and successfully ran install
check for svm and mlp with greenplum.
---
