Github user kaknikhil commented on the issue:

    https://github.com/apache/madlib/pull/249
  
    The changes look good. +1 for adding an install check test.
    
    I noticed that `con_features` is populated by 
`decision_tree.py:_classify_features` which does something like `con_types = 
['real', 'float8', 'double precision', 'numeric']`. Is it better to call the 
utilities function `is_psql_numeric_type`  ? 


---

Reply via email to