Github user kaknikhil commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/250#discussion_r177912480
  
    --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in ---
    @@ -667,7 +678,8 @@ def _validate_dependent_var(source_table, 
dependent_varname,
             if is_classification:
                 # Currently, classification doesn't accept an
                 # array for dep type in IGD
    -            _assert("[]" not in expr_type and expr_type in 
classification_types,
    +            _assert(("[]" in expr_type and expr_type[:-2] in int_types) \
    --- End diff --
    
    why are we checking for only int types and not all numeric types  ? 


---

Reply via email to