Github user njayaram2 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/260#discussion_r180603956
--- Diff:
src/ports/postgres/modules/utilities/minibatch_preprocessing.py_in ---
@@ -397,8 +408,9 @@ class MiniBatchStandardizer:
x_std_dev_str = self.x_std_dev_str)
return query
- def _get_query_for_standardizing_with_grouping(self):
+ def _create_table_for_standardizing_with_grouping(self):
--- End diff --
Why was the method name changed? The older name seems to be more apt, since
this function is still returning the query, and not executing it (the same for
`_create_table_for_standardizing_without_grouping()` too).
Advertising
---
