[GitHub] madlib pull request #272: MLP: Add momentum and nesterov to gradient updates...

[njayaram2]

Github user njayaram2 commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/272#discussion_r191539168
  
    --- Diff: src/modules/convex/task/mlp.hpp ---
    @@ -197,6 +244,7 @@ MLP<Model, Tuple>::loss(
             const model_type                    &model,
             const independent_variables_type    &x,
             const dependent_variable_type       &y_true) {
    +
    --- End diff --
    
    The loss computation code in this function is duplicated in `getLoss()` 
function. Can we call that function to remove the code duplication?


---