Github user iyerr3 commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/291#discussion_r205897828
  
    --- Diff: src/ports/postgres/modules/utilities/utilities.py_in ---
    @@ -221,11 +221,11 @@ def is_psql_numeric_type(arg, exclude=None):
         Returns:
             Boolean. Returns if 'arg' is one of the numeric types
         """
    -    numeric_types = set(['smallint', 'integer', 'bigint', 'decimal', 
'numeric',
    -                         'real', 'double precision', 'serial', 
'bigserial'])
    +    # numeric_types = set(['smallint', 'integer', 'bigint', 'decimal', 
'numeric',
    --- End diff --
    
    These lines (+ other similar lines below) can be deleted. 


---

Reply via email to