Github user orhankislal commented on the issue:

    https://github.com/apache/madlib/pull/318
  
    Thanks for the review @kaknikhil .
    
    1. We had an issue with the knn help messages during one of the releases 
because they didn't show up on the `diff_udf.sql` output. IIRC, the problem was 
that the same function was converted from a pure SQL function to a plpython 
function. I don't have a quick solution to identify such cases.
    2. This indentation should be OK.
    3. We can check if the `new_vers` tag/branch exists and use `master` in its 
place. Alternatively, we can change the comment to avoid using the new version. 
It does not have any functional value.


---

Reply via email to