GitHub user jingyimei opened a pull request:
https://github.com/apache/madlib/pull/323
Build: Add single quote while setting AppendOnly guc
Commit 3db98babe3326fb5e2cd16d0639a2bef264f4b04 added a context manager
for setting appendonly to false for all madlib modules. The commit was
missing a quote around the `gp_default_storage_options` guc because of
which the set command always failed. This commit adds a quote while
setting the guc.
Co-authored-by: Nikhil Kak<[email protected]>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/madlib/madlib test_ao_table
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/madlib/pull/323.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #323
----
commit ebf528f413fc94d9fdeb40045011cb1b374bf12b
Author: Jingyi Mei <jmei@...>
Date: 2018-09-24T18:23:55Z
Build: Add single quote while setting AppendOnly guc
Commit #3db98babe3326fb5e2cd16d0639a2bef264f4b04 added a context manager
for setting appendonly to false for all madlib modules. The commit was
missing a quote around the `gp_default_storage_options` guc because of
which the set command always failed. This commit adds a quote while
setting the guc.
Co-authored-by: Nikhil Kak<[email protected]>
commit b4aabdd1ef0deec4ec89e7acb8dd0c51692a97c9
Author: Jingyi Mei <jmei@...>
Date: 2018-09-24T18:48:51Z
Build: Remove primary key constraint in IC/DC
Some of the install-check/dev-check tests were setting primary key
constraints. If the user sets the GUC
gp_default_storage_options='appendonly=true', IC/DC will fail while
table creation because appendonly tables don't support primary key. This
commit removes these constrains since they are unnecessary for those
test cases.
Co-authored-by: Nikhil Kak <[email protected]>
----
---
