Github user jingyimei commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/326#discussion_r221710452
  
    --- Diff: methods/array_ops/src/pg_gp/test/array_ops.ic.sql_in ---
    @@ -0,0 +1,77 @@
    +/* ----------------------------------------------------------------------- 
*//**
    + *
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + *
    + *//* 
----------------------------------------------------------------------- */
    +---------------------------------------------------------------------------
    +-- Rules:
    +-- ------
    +-- 1) Any DB objects should be created w/o schema prefix,
    +--    since this file is executed in a separate schema context.
    +-- 2) There should be no DROP statements in this script, since
    +--    all objects created in the default schema will be cleaned-up outside.
    +---------------------------------------------------------------------------
    +
    +---------------------------------------------------------------------------
    +-- Setup:
    +---------------------------------------------------------------------------
    +CREATE TABLE data AS
    +SELECT
    +    '{1,2,3}'::float8[] AS an,
    +    '{4,5,7}'::float8[] AS b;
    +
    +SELECT MADLIB_SCHEMA.array_dot(
    --- End diff --
    
    For adding MADLIB_SCHEMA in front of function name: refer to the discussion 
in PR #325 . We need to keep them consistent. 


---

Reply via email to