Github user kaknikhil commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/330#discussion_r222418291
  
    --- Diff: src/ports/postgres/modules/regress/marginal.py_in ---
    @@ -522,9 +520,8 @@ def margins_mlogregr(schema_madlib, source_table, 
out_table,
                 """.format(**all_arguments))
     
             # Rename the output summary table
    -        rename_table(schema_madlib,
    -                     "{old}_summary".format(old=mlog_out_table),
    -                     "{new}_summary".format(new=out_table))
    +        plpy.execute("""CREATE TABLE {out_table}_summary AS
    --- End diff --
    
    can we add a dev-check test to assert that the output summary table should 
exist ?


---

Reply via email to