Github user kaknikhil commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/338#discussion_r234052747
  
    --- Diff: src/ports/postgres/modules/pmml/test/pmml.ic.sql_in ---
    @@ -0,0 +1,119 @@
    +/* ----------------------------------------------------------------------- 
*//**
    + *
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + *
    + *//* 
----------------------------------------------------------------------- */
    +DROP TABLE IF EXISTS abalone CASCADE;
    +
    +CREATE TABLE abalone (
    +    id integer,
    +    sex text,
    +    length double precision,
    +    diameter double precision,
    +    height double precision,
    +    whole double precision,
    +    shucked double precision,
    +    viscera double precision,
    +    shell double precision,
    +    rings integer
    +);
    +
    +INSERT INTO abalone VALUES
    +(3151, 'F', 0.655000000000000027, 0.505000000000000004, 
0.165000000000000008, 1.36699999999999999, 0.583500000000000019, 
0.351499999999999979, 0.396000000000000019, 10),
    --- End diff --
    
    Since this is an install check test, can we cut down on the dataset size 
and call the `glm` and the `pmml` functions only once. 


---

Reply via email to