Github user orhankislal commented on a diff in the pull request:
https://github.com/apache/madlib/pull/343#discussion_r245022983
--- Diff: src/ports/postgres/modules/regress/linear.py_in ---
@@ -134,11 +170,11 @@ def linregr_train(schema_madlib, source_table,
out_table,
'linregr'::varchar as method
, '{source_table}'::varchar as source_table
, '{out_table}'::varchar as out_table
- , '{dependent_varname}'::varchar as
dependent_varname
- , '{independent_varname}'::varchar as
independent_varname
+ , $${dependent_varname}$$::varchar as
dependent_varname
+ , $${independent_varname}$$::varchar as
independent_varname
, {num_rows_processed}::integer as
num_rows_processed
, {num_rows_skipped}::integer as
num_missing_rows_skipped
- , {grouping_col}::text as grouping_col
+ , $${grouping_col}$$::text as
grouping_col
--- End diff --
These additional quotes around the grouping columns break the PMML tests.
---
