fmcquillan99 commented on issue #352: Feature/kd tree knn URL: https://github.com/apache/madlib/pull/352#issuecomment-465693737 Functionality LGTM Please make a couple minor user doc formatting changes: (1) There are a bunch of cases that the user docs show as: "and it looks for $k$ closest points in the tree..." "In the prediction phase, $k$ is a user-defined constant..." "For example, a tree of depth 3 will have a total of $2^3 = 8$ regions." etc. so please do a global search and fix the formatting, maybe this is supposed to be italic? (2) Missing a period at the very end of the technical background section
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
