njayaram2 commented on a change in pull request #356: Keras model arch table helper functions for keras_fit() URL: https://github.com/apache/madlib/pull/356#discussion_r266090893
########## File path: src/ports/postgres/modules/convex/keras_model_arch_table.py_in ########## @@ -0,0 +1,132 @@ +# coding=utf-8 +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +""" +@file keras_model_arch_table.py_in + +@brief keras model arch table management helper functions + +@namespace keras_model_arch_table +""" + +from utilities.validate_args import table_exists +from utilities.validate_args import columns_missing_from_table +from utilities.validate_args import quote_ident +from utilities.control import MinWarning +from internal.db_utils import quote_literal +from utilities.utilities import unique_string +import plpy + Review comment: We normally have online docs in the .py_in file of a module. Please refer to [this](https://github.com/apache/madlib/blob/master/src/ports/postgres/modules/utilities/minibatch_preprocessing.py_in#L594) for more info on what kind of information is included in the online documentation. Note that we only provide the usage, and not examples here. Examples are only included in the user docs (sql file). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
