kaknikhil commented on a change in pull request #355: Keras fit interface URL: https://github.com/apache/madlib/pull/355#discussion_r266102765
########## File path: src/ports/postgres/modules/convex/madlib_keras.py_in ########## @@ -17,24 +17,27 @@ # specific language governing permissions and limitations # under the License. -import plpy -import keras -import numpy as np -import time import datetime import os -from keras.models import * +import plpy +import time + +from keras import backend as K +from keras import utils as keras_utils from keras.layers import * +from keras.models import * from keras.optimizers import * -from keras import backend as K from keras.regularizers import * -from utilities.validate_args import output_tbl_valid -from utilities.validate_args import input_tbl_valid -from utilities.utilities import add_postfix -from utilities.utilities import madlib_version +import numpy as np Review comment: I understand that all the unit tests are passing even after the refactor but ideally we should also separate the unit test code to be consistent with the refactored code. We can keep all the test code in file and use test classes to separate the code. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
