reductionista commented on a change in pull request #356: Keras model arch
table helper functions for keras_fit()
URL: https://github.com/apache/madlib/pull/356#discussion_r267128808
##########
File path: src/ports/postgres/modules/convex/keras_model_arch_table.py_in
##########
@@ -121,13 +118,116 @@ def delete_keras_model(keras_model_arch_table,
model_id, **kwargs):
res = _execute(sql)
if res.nrows() > 0:
- plpy.info("Model id {0} has been deleted from {1}.".format(model_id,
model_arch_table))
+ plpy.info("Keras Model Arch: Model id {0} has been deleted from {1}.".
+ format(model_id, model_arch_table))
else:
- plpy.info("Model id {0} not found".format(model_id))
+ plpy.error("Keras Model Arch: Model id {0} not found".format(model_id))
Review comment:
I still think a warning would be better here than an error. See below for
one reason why.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
