njayaram2 commented on a change in pull request #364: WCC: Performance
Improvement
URL: https://github.com/apache/madlib/pull/364#discussion_r273727826
##########
File path: src/ports/postgres/modules/graph/wcc.py_in
##########
@@ -289,6 +291,9 @@ def wcc(schema_madlib, vertex_table, vertex_id,
edge_table, edge_args,
SELECT COUNT(*) AS cnt FROM {toupdate}
""".format(**locals()))[0]["cnt"]
+ if not is_platform_pg():
+ # Drop intermediate table created for Greenplum
+ plpy.execute("DROP TABLE IF EXISTS {edge_inverse}".format(**locals()))
Review comment:
`plpy.execute("DROP TABLE IF EXISTS {0}".format(edge_inverse))` might be
better. I can make the change before merging this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
