kaknikhil commented on a change in pull request #375: DL: Add GPU support for 
evaluate
URL: https://github.com/apache/madlib/pull/375#discussion_r278351762
 
 

 ##########
 File path: src/ports/postgres/modules/deep_learning/madlib_keras.py_in
 ##########
 @@ -503,6 +525,21 @@ def internal_keras_evaluate(dependent_var, 
independent_var, model_architecture,
     independent_var = expand_input_dims(independent_var, target_type='float32')
     dependent_var = expand_input_dims(dependent_var)
 
+
     with K.tf.device(device_name):
         res = model.evaluate(independent_var, dependent_var)
+    if current_seg == -1:
 
 Review comment:
   We should use `is_platform_pg()` instead of `current_seg` for this if check. 
It reflects the true intent of the if check 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to