kaknikhil commented on a change in pull request #380: DL: Add negative unit
tests for unsupported compile and fit params
URL: https://github.com/apache/madlib/pull/380#discussion_r279889199
##########
File path:
src/ports/postgres/modules/deep_learning/test/unit_tests/test_madlib_keras.py_in
##########
@@ -443,6 +443,79 @@ class MadlibKerasFitTestCase(unittest.TestCase):
accepted_fit_params)
self.assertDictEqual(result_params, target_dict)
+ def test_parse_and_validate_compile_params_invalid_metrics(self):
Review comment:
Can the name of the unit test be more specific about the failure? For ex
it's hard to know why the metrics are invalid. Maybe something like
`test_parse_and_validate_compile_params_dict_metrics_fail`
This applies to all the other functions as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
