kaknikhil commented on a change in pull request #383: Dl/remove hardcode
URL: https://github.com/apache/madlib/pull/383#discussion_r280962195
##########
File path: src/ports/postgres/modules/deep_learning/madlib_keras.sql_in
##########
@@ -158,12 +161,13 @@ CREATE AGGREGATE MADLIB_SCHEMA.fit_step(
/* architecture */ TEXT,
/* compile_params */ TEXT,
/* fit_params */ TEXT,
- /* use_gpu */ BOOLEAN,
+ /* gpus_per_host */ INTEGER,
+ /* segments_per_host */ INTEGER,
/* previous_state */ BYTEA
)(
STYPE=BYTEA,
SFUNC=MADLIB_SCHEMA.fit_transition,
- m4_ifdef(`__POSTGRESQL__', `', `prefunc=MADLIB_SCHEMA.fit_merge,')
Review comment:
Turns out the postgres throws a warning saying `aggregate attribute
"prefunc" not recognized` but does not fail. I think it's safer to have the if
check so i will revert this to the original m4 ifdef.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
