orhankislal commented on issue #385: DL: Improve parameter parsing and add unit tests URL: https://github.com/apache/madlib/pull/385#issuecomment-491984889 @fmcquillan99 Thanks for the comments. The scope of this PR has changed a bit. I changed the title to reflect it. 1. no metrics: The parsing code allows dropping the metrics parameter but a different part of the code still requires it. A future PR will drop that requirement which will fix the issue. Currently, we do require a metric. 1. no loss: The error message is correct. 1. no fit: There was a minor bug which should be fixed now. We will allow both NULL and an empty string for fit_params.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
