njayaram2 commented on a change in pull request #397: DL: Update content of
the model summary table
URL: https://github.com/apache/madlib/pull/397#discussion_r288349547
##########
File path: src/ports/postgres/modules/deep_learning/madlib_keras_wrapper.py_in
##########
@@ -160,7 +172,7 @@ def parse_and_validate_compile_params(str_of_args):
opt_args: Arguments for the optimizer
compile_dict: Dictionary of arguments for keras.compile
"""
-
+ _assert(str_of_args, "Compile parameters cannot be empty or NULL.")
Review comment:
True, the value here will not be NULL, but the value passed by the user can
be either empty or NULL. Since we convert a `None` to empty string in the other
code you pointed out, we won't know the original value exactly here. So made
the error message generic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
