reductionista commented on a change in pull request #424: DL: Add function for predict bring your own model URL: https://github.com/apache/madlib/pull/424#discussion_r309871725
########## File path: src/ports/postgres/modules/deep_learning/madlib_keras.sql_in ########## @@ -616,6 +617,127 @@ madlib_keras_predict( </DD> </DL> + Review comment: `madlib_keras.sql_in` is getting very long (over 2000 lines now). I think it's time we split this up like we did for `madlib_keras.py_in`. (Either now or in a future PR.) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
